[PS] Migrate StorageMover module to autorest v4 #28333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
To the author of the pull request, |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the StorageMover module from autorest v3 to autorest v4, updating the code generation framework and maintaining API compatibility. The migration includes comprehensive updates to generated models, parameter sets, documentation, and test configurations.
- Updates autorest framework from v3 to v4 for improved code generation
- Refreshes all generated PowerShell cmdlets and documentation with new parameter sets and model types
- Maintains backward compatibility through breaking change exceptions for enum type changes
Reviewed Changes
Copilot reviewed 77 out of 77 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.StorageMover/BreakingChangeIssues.csv | Documents expected breaking changes from enum types to strings during migration |
| src/StorageMover/StorageMover/help/*.md | Updates help documentation with new parameter sets and model namespaces |
| src/StorageMover/StorageMover.Autorest/test/Get-AzStorageMoverJobRun.Tests.ps1 | Fixes test to access JobRunResourceId property correctly |
| src/StorageMover/StorageMover/Az.StorageMover.psd1 | Updates module dependencies and generation timestamp |
| src/StorageMover/StorageMover.sln | Refreshes solution file with updated project configurations |
Comments suppressed due to low confidence (1)
src/StorageMover/StorageMover.Autorest/test/Get-AzStorageMoverJobRun.Tests.ps1:23
- The property name 'JobRunResourceId1' appears to have an inconsistent suffix '1'. Consider using a more descriptive property name like 'JobRunResourceId' or verify this is the correct property name.
$jobRunName = $job.JobRunResourceId1.Split("/")[-1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.